Skip to content

fix(server): refresh model catalog without CLI update checks - #69

Closed
macodev00 wants to merge 1 commit into
mainfrom
cursor/model-manifest-independent-of-cli-checks-499c
Closed

macodev00 wants to merge 1 commit into
mainfrom
cursor/model-manifest-independent-of-cli-checks-499c

Conversation

@macodev00

@macodev00 macodev00 commented Oct 1, 2026 •

Copy link
Copy Markdown
Owner

Fixes pingdotgg#13244

What Changed

enableProviderUpdateChecks no longer gates the remote model-manifest fetch. ModelManifest.refresh and forceRefresh still update the catalog when Settings → General → Provider update checks is off. CLI version lookups stay behind that switch.

Why

The setting is described as checking installed provider CLI versions, but the same flag returned before ModelManifest fetched model-manifest.json. New models that exist only on the remote catalog stayed out of the picker until the switch was turned back on, including an explicit Refresh provider status.

Verification

From apps/server on Node 24.13.1:

vp test run src/provider/ModelManifest.test.ts

Result: 1 file passed, 16 tests passed (1.01s). This includes fetches the remote manifest when provider update checks are disabled, which covers both the TTL refresh and explicit forceRefresh.

vp test run src/provider/providerMaintenance.test.ts -t "does not fetch latest provider versions when update checks are disabled"

Result: 1 passed, 27 skipped. CLI version lookups stay gated by the setting.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • No UI changes
  • No animation or interaction changes

Implemented by Grok 4.7 in Cursor.

Open in Web Open in Cursor 

Provider update checks skipped both CLI version lookups and the remote
model-manifest fetch, so new models stayed out of the picker until the
setting was turned back on.

Catalog refresh now ignores that switch. CLI version checks stay gated.
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL labels Oct 1, 2026
@macodev00

Copy link
Copy Markdown
Owner Author

Opened upstream.

@macodev00 macodev00 closed this Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Disabling CLI update checks also blocks new model catalog

1 participant