Repository navigation
Conversation
…ctories Git's relative --git-common-dir is computed from the physical working directory. path.resolve applied ".." to the symlink path, so a project opened through a symlink into a repository subdirectory pointed GIT_INDEX_FILE at a missing directory and checkpoint capture exited 128 on every turn. Ask Git for the absolute common directory before joining it with the project path. Repository path lookup uses that same absolute directory, then realpath, so later --git-dir reads stay in the real repository. Fixes pingdotgg#13187
github-actions
Bot
added
vouch:trusted
Owner
Author
|
Superseded by upstream READY PR on pingdotgg/t3code (same branch). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Checkpoint capture and repository path lookup now ask Git for an absolute
--git-common-dirbefore joining it with the project path.Why
Opening a project through a symlink that points at a repository subdirectory made every turn fail checkpoint capture with exit 128. Git's relative
--git-common-diris computed from the physical working directory, andpath.resolveapplied..to the symlink string, so the temporary index was created in a directory that does not exist. Diffs and Go back stayed unavailable for that thread.The same join in repository path lookup could cache that missing directory, or a different repository's
.gitwhen the lexical path happened to exist. Both call sites now use--path-format=absolute, which checkpoint capture already uses for--git-path index.realPathstill runs afterward so Windows 8.3 short names collapse.Fixes pingdotgg#13187
Checklist
Model: Grok 4.7
Harness: Cursor cloud agent