Skip to content

[year2025day02] Refactor code #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maciej7777 merged 1 commit into from
Dec 2, 2025
Merged

[year2025day02] Refactor code #177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/main/java/com/example/adventofcode/year2025/day02/GiftShop.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public static long sumInvalidIdsByNewRules(final String filename) throws IOExcep
return count;
}

private static List<Interval> generateIntervals(List<String> lines) {
private static List<Interval> generateIntervals(final List<String> lines) {
List<Interval> intervalList = new ArrayList<>();
for (String line : lines) {
String[] elements = line.split(",");
Expand All @@ -76,8 +76,10 @@ private static List<Interval> generateIntervals(List<String> lines) {
return intervalList;
}

private static boolean checkIfNumberIsSpecial(String number, int length, int j) {
if (length % j == 0) {
private static boolean checkIfNumberIsSpecial(final String number, final int length, final int j) {
if (length % j != 0) {
return false;
} else {
for (int k = 1; k < j; k++) {
String previous = number.substring(number.length() * (k - 1) / j, (number.length() * k / j));
String next = number.substring(number.length() * k / j, (number.length() * (k + 1) / j));
Expand All @@ -86,8 +88,6 @@ private static boolean checkIfNumberIsSpecial(String number, int length, int j)
return false;
}
}
} else {
return false;
}

return true;
Expand Down
Loading