Skip to content

Feature/sort - #29

Merged
macedot merged 5 commits into
masterfrom
feature/sort
Sep 3, 2026
Merged

macedot merged 5 commits into
masterfrom
feature/sort

Conversation

@macedot

@macedot macedot commented Sep 3, 2026

Copy link
Copy Markdown
Owner

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Testing

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Screenshots

…tinue

Importing events where a bounded event (e.g. a loan) ended later than the
default period set the simulation end exactly at that endDate, silently
truncating open-ended events: an open-ended salary lost its payment in the
month after the loan's last payment, and the whole result stopped there.

When open-ended events exist, the auto-expanded period now extends one
month past the last bounded endDate (clamped to month length) so their
recurrence stays visible beyond it. Bounded-only and open-ended-only
imports behave exactly as before.
…able

- Sort Period/Freq/Value columns: click cycles asc -> desc -> clear,
  with aria-sort state and per-theme active accent styling
- Reorder rows manually via native HTML5 drag and drop; dragging clears
  any active column sort
- Extract pure comparators to src/eventSort.js (stable sort, open-ended
  events last, frequency ranked by recurrence length)
- Sorted/dragged order persists to localStorage; table re-simulates so
  results Items follow the new order
- Unit tests (12) + E2E tests for sorting and drag reorder
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 3, 2026

Copy link
Copy Markdown

Deploying cashflow-js with  Cloudflare Pages  Cloudflare Pages

Latest commit: d4e3fd9
Status: ✅  Deploy successful!
Preview URL: https://ae5a696b.cashflow-js.pages.dev
Branch Preview URL: https://feature-sort.cashflow-js.pages.dev

View logs

@macedot
macedot merged commit 0aad95c into master Sep 3, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant