Bug fix fixes bww imported single timings that should be second timings#25
Conversation
…ings Added new method in controller that Fixes BWW imported single timings that should be second timings Added .vscode folder to .gitignore
Removed extraneous imports
Removed commented imports
|
Thank you, this is a useful feature. I'd prefer to do it in the ImportBWW parser itself - adding a lastToken field to the Parser, and then in timelineStart() it can check if the last token was a TIME_LINE_END and if so it can remove the last timing (if it was a single timing) and create the second timing. The advantage of that is that it means we don't have to leak the StartNote/EndNote from the Timings, and also it's a bit faster (although that's not a huge problem for BWW importing). If you'd like to do this, that'd be great, otherwise I'm happy to (I realise you've probably moved on to other things!). Also, I'm sorry it's taken so long to review these pull requests! Thank you very much for putting in the effort, I appreciate it. |
|
Hi macarc yes, I have well and truly moved on,I think your bww import change is much better solution than mine, at the time I was more familiar with the json structure. So yes please make the Bww changes. I have made many enhancements on my fork under branch The-works. I’m not sure you are interested but let me know and I’ll prepare some pull requests. regards Andy |
Added new method in controller that Fixes BWW imported single timings that should be second timings
Added .vscode folder to .gitignore