This repository was archived by the owner on Jul 29, 2025. It is now read-only.
Open
Conversation
43c009f to
5144bf5
Compare
062c2ac to
96180c4
Compare
7bc1564 to
0e01781
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Added
getDateTime()andsetDateTime()Changed
_wirewhich is a reference to a TwoWire instance. Users can select which instance to use (Wire or Wire1). Default: Wire (no change)begin()accepts parameters forTwoWire::begin()to give users flexiblity.Removed
getTime(void)Fixed
setAlarmIRQ(const rtc_time_t)(see Update BM8563.cpp M5Core-Ink#3)Note
No API breakage except for removing
getTime(void).I believe this is not an issue because this function only sets a private member variable
trdatato data from BM8563, andtrdatais not used in the other functions.