Repository navigation
feat: refuse look-alike names, mark verified senders, and record them in the log - #114
Merged
Merged
Conversation
… in the log A reserved handle now also reserves every name that looks like it: identity_skeleton() folds invisible characters, separators, fullwidth forms, common Cyrillic, Greek and Latin look-alikes, case, 0 1 i | and rn, vv the same way m1ngsama ID does, and the nickname prompt, :nick, exec post, module senders and the SSH none-auth check compare skeletons. identity.reserve now renames unverified look-alike holders the way identity.verified already did, through the same function. Messages from verified senders show a check mark after the name in the chat view, :last and :search, and :users marks signed-in sessions. No nickname may contain a check mark. messages.log moves to v3: each record gains a flags field, v for a verified sender. v1 and v2 logs are migrated in place at start with a backup. Exec tail and dump output is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs your call:
messages.log.v2.bakand losing messages written since (tnt-message-log.5).A reserved handle could still be imitated with look-alike characters, terminal users had no way to tell a signed-in member from a stranger, and past messages could only guess who was verified.
0/o,1/l/i,rn/m,vv/wcount as the same. m1ngsama ID uses the same rules. This covers the nickname prompt,:nick, exec post, module senders andssh HANDLE@host.identity.reservenow renames any unverified session using the handle or a look-alike, likeidentity.verifieddid.✓after their name in the chat view,:users,:lastand:search. Nicknames may not contain check marks.vmarks a verified sender. v1 and v2 logs migrate in place at start, with a backup, and old records stay unverified. Exectailanddumpoutput is unchanged.make testpasses.