Repository navigation
feat(module): let app users appear in :users and exchange private messages - #112
Merged
Merged
Conversation
… app users A module granted message:private reports the users online through it with presence.remote. SSH users see them in :users, marked app, in the status bar's online count, and in nickname completion. :msg, :w and :reply to a remote name reach the module as private.created, and private.post delivers a remote user's private message to SSH sessions like one from another SSH user. At most one module holds the permission, and its remote users are cleared when it stops or is disabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs your call:
:usersand the status bar now count app users; execusersandstatsstill count SSH sessions only, since they are the machine API (src/commands.c).App users joined through the gateway were invisible to terminal users, and private messages only worked between SSH sessions.
message:private, held by at most one module.presence.remotegives the full set of app users. They show in:usersmarked· app, in nickname completion, and as:msgtargets. The set clears when the module stops.:msgand:replyto an app user emitprivate.createdwith averifiedflag. An SSH session with the same name still wins.private.postdelivers an app user's message to an SSH user's inbox like any private message. Private messages stay out of the log and out ofmessage.created.make testpasses, with 11 new checks intest_module_private.sh.