script for transferring swap facility ownership to timelock - #71
Merged
Conversation
ith-harvey
marked this pull request as draft
November 15, 2025 23:32
Changes to gas cost
🧾 Summary (20% most significant diffs)
Full diff report 👇
|
LCOV of commit
|
ith-harvey
marked this pull request as ready for review
November 17, 2025 00:25
PierrickGT
approved these changes
Nov 17, 2025
toninorair
reviewed
Nov 17, 2025
toninorair
reviewed
Nov 17, 2025
toninorair
self-requested a review
November 17, 2025 21:29
toninorair
approved these changes
Nov 17, 2025
PierrickGT
pushed a commit
that referenced
this pull request
Dec 10, 2025
* added script for transfering swap facility timelock * updated script after test run and included common off of main branch * removed unused swap facility import * updated script to hardcoded mainnet timelock * fixed make file, removing run arg * updated DEFAULT_ADMIN to match eng multisig per Toni's request
PierrickGT
pushed a commit
that referenced
this pull request
Dec 10, 2025
* added script for transfering swap facility timelock * updated script after test run and included common off of main branch * removed unused swap facility import * updated script to hardcoded mainnet timelock * fixed make file, removing run arg * updated DEFAULT_ADMIN to match eng multisig per Toni's request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the scripting and Makefile tasks required to propose a transfer of the SwapFacility ownership to the appropriate timelock controller. These changes follow the same batching and multisig execution pattern used previously in m-portal-lite, allowing us to coordinate the upgrade alongside the broader timelock execution work.
Motivation:
The SwapFacility needs to transfer its ProxyAdmin ownership and DEFAULT_ADMIN_ROLE
to the chain-specific timelock as part of the upcoming upgrade. No script
existed in evm-m-extensions to generate the required batched multisig proposal,
so this PR introduces that logic using the batch utilities from common.
Changes:
sequence for:
• transferring ProxyAdmin ownership
• granting the admin role to the timelock
• renouncing current multisig admin authority
for the owner transfer
utilities required by the script
Note on common submodule update:
I updated the common submodule to the latest main commit in order to bring in
the MultiSigBatchBase utilities. This was not done through a versioned release.
If the team prefers that we follow the release/tag pattern for common, I am
happy to cut a new release there and update the submodule reference to point
to that release instead. Once a new tagged release exists, I can update this PR
(or a follow-up PR) to reference it.