Skip to content

Add a basic HTML page for the default endpoint in ndt7-prometheus-exporter - #84

Open
fhltang wants to merge 2 commits into
m-lab:mainfrom
fhltang:webui
Open

fhltang wants to merge 2 commits into
m-lab:mainfrom
fhltang:webui

Conversation

@fhltang

@fhltang fhltang commented Sep 25, 2022

Copy link
Copy Markdown
Contributor

This is a small follow up to PR #77 .


This change is Reviewable

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 193

  • 35 of 98 (35.71%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-16.0%) to 73.301%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/ndt7-prometheus-exporter/main.go 0 5 0.0%
cmd/ndt7-prometheus-exporter/web.go 35 93 37.63%
Files with Coverage Reduction New Missed Lines %
internal/upload/upload.go 2 96.4%
Totals Coverage Status
Change from base Build 192: -16.0%
Covered Lines: 766
Relevant Lines: 1045

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants