fix: Uneven space around BEGIN button#208
Open
Ayush4958 wants to merge 2 commits into
Open
Conversation
Contributor
|
Thanks for working on this! The spacing issue is real, but I think the fix should address the root cause rather than work around it with a margin. I think the actual problem is that the "Please agree to the data policy" message is laid out side-by-side with the BEGIN button (via the .row/.col-6 grid). That looks awkward - the message floats to the right of the button with mismatched vertical alignment. A better fix would be to remove the .row/.col-6 wrapper around the button and privacy message entirely, and just stack them vertically. That would naturally fix the spacing without needing a magic 34px margin. |
Author
|
Yes you are right , |
Author
Signed-off-by: Ayush <bhandariayush935@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Solution
Increases the margin from the bottom of the component which manages the uneven space around it
Checks
Also checked in the responsive manner.
Preview
This change is