Repository navigation
Add real-tool .schem fixtures, flat-v3 codec support and importer tests - #24
Merged
Merged
Conversation
lzif
force-pushed
the
feat/real-schem-fixtures
branch
from
November 16, 2026 09:59
225ba4e to
e37e1f0
Compare
Add the real-tool .schem and legacy .schematic fixtures from schem-file.zip under fixtures/real/:
- fixtures/real/worldedit/fantasyhouse2.schem (WorldEdit 7.4.6, Sponge v3, DataVersion 5023)
- fixtures/real/shulkr/{castelo-medieval,raifox-medivial-house,simple-survival-mansion}.schem (Shulkr, Sponge v3)
- fixtures/real/flat-v3/smp_lobby_{big,center_dense,medieval}.schem (flat Sponge v2 layout stamped Version 3)
- fixtures/real/legacy/storageroom-medieval.schematic (pre-1.13 MCEdit Alpha format)
Update readSchem() to accept real-world .schem files that declare Version 3 while using Sponge v2's flat top-level layout (Palette and BlockData without Schematic/Blocks) with a warning, and rebuild skills/voxwright/scripts/voxwright-cli.mjs.
Add real-fixture, convert, skill-CLI inspect, and end-to-end scripts/convert.ts -> mcbuilder importer tests verifying block-for-block identity across real .schem builds (issues #10 and #11).
lzif
force-pushed
the
feat/real-schem-fixtures
branch
from
November 16, 2026 10:27
e37e1f0 to
50555e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10
Closes #11
Summary
.schem&.schematicfixtures added underfixtures/real/:worldedit/fantasyhouse2.schem: WorldEdit 7.4.6 (enginehub:fabric), Sponge v3, DataVersion 5023 (44×39×34,Offset: [-18, -13, -32], 22,953 blocks, 342 palette entries exercising 2-byte varints, 93 block entities, 41 entities)shulkr/{castelo-medieval,raifox-medivial-house,simple-survival-mansion}.schem: Sponge v3 builds exported by Shulkr (DataVersion 5023)flat-v3/smp_lobby_{big,center_dense,medieval}.schem: real-world.schemfiles (DataVersion 3465) that stampVersion: 3on a flat Sponge v2 layoutlegacy/storageroom-medieval.schematic: real pre-1.13 MCEditMaterials: "Alpha"file for legacy rejection testingreadSchem(packages/core/src/codecs/schem.ts):Palettecompound +BlockDatabyte array at top level, withoutSchematic/Blocks) whenVersion === 3, reading via v2 layout and emitting"Version is 3, but layout is Sponge v2 (read using v2 layout)", while still rejecting mismatched or malformed headers.skills/voxwright/scripts/voxwright-cli.mjs.packages/core/test/real-fixtures.test.ts&schem.test.ts: fixture decoding, metadata/entity preservation, format round-trips, flat-v3 layout warning, and legacy rejection.packages/core/test/convert.test.ts: real.schem->.nbtand flat-v3 warning tests.packages/mcbuilder/test/importer.test.ts: end-to-end tests runningscripts/convert.tsonfantasyhouse2.schem,raifox-medivial-house.schem, andsmp_lobby_big.schem, feeding the.nbtoutputs intomcbuilder's importer, and verifying block-for-block identity (plus 1.20minecraft:chain->minecraft:iron_chainrename handling).packages/mcbuilder/test/skill-cli.test.ts:voxwright-cli inspectchecks on real WorldEdit and flat-v3.schemfiles.fixtures/README.md,PLAN.md, andREADME.md.Verification (rebased onto
d3d1f4e)pnpm run check(0 errors, exit 0) &pnpm exec biome format .(0 errors)pnpm run depcheck(397 modules, 1133 dependencies cruised, 0 violations)pnpm run typecheck(core,render,web,mcbuilder,scripts— 0 errors)node scripts/build-skill.ts --check&node scripts/pack-npm.ts --dry-runpnpm test(71 passed (71),1917 passed | 190 skipped (2107))