Repository navigation
Fix scoped core, mcbuilder, and web bugs (Refs #22) - #23
Merged
Merged
Conversation
lzif
force-pushed
the
fix/issue-22-bugs
branch
from
November 16, 2026 00:26
a6e8a04 to
0136c92
Compare
This was referenced Nov 16, 2026
lzif
added a commit
that referenced
this pull request
Nov 16, 2026
Fix scoped core, mcbuilder, and web bugs (Refs #22)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #22
Fixes the scoped, non-architectural bugs reported in #22 and updates the bundled skill CLI (
9d077abalready landed#22item#12onmain, so this PR builds cleanly on top ofa4b5020):@voxwright/core(bedrockcodec — #22 item #8)minecraft:cornerandminecraft:connection_*states and writeminecraft:connection_*as NBTTAG_Byte(1) instead ofTAG_Int.end_rodand(?:.*_)?lightning_rod(all copper oxidation/waxed variants) toFACING_DIRECTION_BLOCKS(facing_direction0..5andpowered_bit).campfireandsoul_campfireextinguished<->lit(with Java defaultlit=trueand consumingsignal_fire=falsewithout false warnings while still reportingsignal_fire=true).bellbidirectionally (attachment,direction,toggle_bit<->attachment,facing,powered) without leakingcardinal_direction/powered_bit.@voxwright/mcbuilder&skills/voxwright(#22 items #2, #5, #6, #11, P2)seed?: Seedtopatches()while keeping unseeded calls identical for golden vector parity.mcbuild.tomlmax_dimensionsbeforeloadScript, enforce both relaxed defaults and tightened upper bounds acrosscliandskill build(--jsonincluded).assets_dircandidate resolution (<assetsDir>and<assetsDir>/<mcVersion>) acrossloadRegistry,cmdRunpreviews/--guide/version.json,cmdPalette, andskill build/findRegistrywithout auto-downloading into~/.cache/mcbuilderwhenassets_diris set.iso-> first non-topview -> first view forguide/guide.mdcover when--previewruns (while keepingcover: nullwhen--previewis omitted).mcbuild diff, sorting numericrun-*directories and choosing the last two clean runs (with.nbtartifacts).skills/voxwright/scripts/voxwright-cli.mjs(pnpm build:skill).@voxwright/web(#22 items #9, #10, #13d)EditSession.inspectAt()and[data-testid="at-inspect"](Inspect) button inSelectionPanel(treating explicitminecraft:airas empty ininspectedBlocktoo).hoverstate/highlights acrossapplyHover,replace,setProperty, brush strokes, cancels, andundo/redoviasyncHover()and brush drag ordering.skipAirlabels to(paste, move and rotate).Verification (rebased on
a4b5020)pnpm run check(Biome)pnpm run depcheck(depcruise: 0 violations across 395 modules)pnpm run typecheck(core,render,mcbuilder,web+scripts/tsconfig.json: 0 errors/warnings)node scripts/build-skill.ts --checknode scripts/pack-npm.ts --dry-runpnpm test(vitest run: 70 files passed, 1862 passed / 190 optional vanilla-asset tests skipped locally)node apps/web/test/e2e.ts341 checks passed &pnpm test:touch804 checks passed prior to rebase with zeroapps/web,core, orrenderchanges onmain)