Skip to content

Fix scoped core, mcbuilder, and web bugs (Refs #22) - #23

Merged
lzif merged 1 commit into
mainfrom
fix/issue-22-bugs
Nov 16, 2026
Merged

lzif merged 1 commit into
mainfrom
fix/issue-22-bugs

Conversation

@lzif

@lzif lzif commented Nov 15, 2026 •

Copy link
Copy Markdown
Owner

Refs #22

Fixes the scoped, non-architectural bugs reported in #22 and updates the bundled skill CLI (9d077ab already landed #22 item #12 on main, so this PR builds cleanly on top of a4b5020):

@voxwright/core (bedrock codec — #22 item #8)

  • Keep vanilla Bedrock 1.21.130+ minecraft:corner and minecraft:connection_* states and write minecraft:connection_* as NBT TAG_Byte (1) instead of TAG_Int.
  • Add end_rod and (?:.*_)?lightning_rod (all copper oxidation/waxed variants) to FACING_DIRECTION_BLOCKS (facing_direction 0..5 and powered_bit).
  • Map campfire and soul_campfire extinguished <-> lit (with Java default lit=true and consuming signal_fire=false without false warnings while still reporting signal_fire=true).
  • Map bell bidirectionally (attachment, direction, toggle_bit <-> attachment, facing, powered) without leaking cardinal_direction/powered_bit.

@voxwright/mcbuilder & skills/voxwright (#22 items #2, #5, #6, #11, P2)

  • CI: GitHub Actions per path #2: Add optional seed?: Seed to patches() while keeping unseeded calls identical for golden vector parity.
  • core/blocks: block-state parsing and canonical strings #5: Resolve mcbuild.toml max_dimensions before loadScript, enforce both relaxed defaults and tightened upper bounds across cli and skill build (--json included).
  • core/rotation: port of rotation.py #6: Unify assets_dir candidate resolution (<assetsDir> and <assetsDir>/<mcVersion>) across loadRegistry, cmdRun previews/--guide/version.json, cmdPalette, and skill build/findRegistry without auto-downloading into ~/.cache/mcbuilder when assets_dir is set.
  • Fixtures: real-tool .schem files #11: Pick iso -> first non-top view -> first view for guide/guide.md cover when --preview runs (while keeping cover: null when --preview is omitted).
  • P2: Support 0-arg mcbuild diff, sorting numeric run-* directories and choosing the last two clean runs (with .nbt artifacts).
  • Rebuild skills/voxwright/scripts/voxwright-cli.mjs (pnpm build:skill).

@voxwright/web (#22 items #9, #10, #13d)

  • Codec .schem (Sponge v2 and v3) #9: Add EditSession.inspectAt() and [data-testid="at-inspect"] (Inspect) button in SelectionPanel (treating explicit minecraft:air as empty in inspectedBlock too).
  • convert script: .schem to .nbt #10: Fix stale hover state/highlights across applyHover, replace, setProperty, brush strokes, cancels, and undo/redo via syncHover() and brush drag ordering.
  • #13d: Update both touch and desktop skipAir labels to (paste, move and rotate).

Verification (rebased on a4b5020)

  • pnpm run check (Biome)
  • pnpm run depcheck (depcruise: 0 violations across 395 modules)
  • pnpm run typecheck (core, render, mcbuilder, web + scripts/tsconfig.json: 0 errors/warnings)
  • node scripts/build-skill.ts --check
  • node scripts/pack-npm.ts --dry-run
  • pnpm test (vitest run: 70 files passed, 1862 passed / 190 optional vanilla-asset tests skipped locally)
  • Chromium E2E (node apps/web/test/e2e.ts 341 checks passed & pnpm test:touch 804 checks passed prior to rebase with zero apps/web, core, or render changes on main)

@lzif
lzif force-pushed the fix/issue-22-bugs branch from a6e8a04 to 0136c92 Compare November 16, 2026 00:26
@lzif
lzif merged commit d48fb56 into main Nov 16, 2026
6 checks passed
lzif added a commit that referenced this pull request Nov 16, 2026
Fix scoped core, mcbuilder, and web bugs (Refs #22)
@lzif
lzif deleted the fix/issue-22-bugs branch November 16, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant