chambers-yamasaki submission#5
Open
ayamasaki2011 wants to merge 6 commits into
Open
Conversation
lyy005
reviewed
Oct 12, 2017
| import matplotlib.pyplot as plt | ||
| plt.plot(UWscore['time'], UWscore['cum_sum'], 'r-', MSUscore['time'], | ||
| MSUscore['cum_sum'], 'g-') | ||
|
|
Owner
There was a problem hiding this comment.
Good job. The graph looks good and the way you use to calculate the cumulative sum is great.
The only problem is that when you plot two lists, the graph will make a straight line to connect two data points. The score of the intermediate score may not be correct
lyy005
reviewed
Oct 12, 2017
| guess=int(input(prompt="Your guess:")) #Store a guess from the user | ||
|
|
||
| while guess != answer: #Test if the user input is right | ||
| if guess < answer: #If not, test whether the guess is lower or higher than the answer |
Owner
There was a problem hiding this comment.
The code looks good. You may want to put "guess=int(input(prompt="Your guess:"))" within the while loop so that you don't need to run the code after the first input
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.