Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/primary.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,18 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout repo
uses: actions/checkout@v4
uses: actions/checkout@v7
with:
persist-credentials: false # recommended: do not persist git credentials on disk

- name: Setup pnpm
uses: pnpm/action-setup@v4
with:
version: 9.6.0
uses: pnpm/setup@v2

- name: Setup node 24
uses: actions/setup-node@v4
uses: actions/setup-node@v7
with:
node-version: 24
cache: pnpm
package-manager-cache: false # recommended: avoid cache poisoning

- run: pnpm install
- run: pnpm test
Expand Down
23 changes: 12 additions & 11 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,31 +2,32 @@ name: publish

on: workflow_dispatch

permissions:
contents: write # to check out repo (actions/checkout) and to create releases (changesets/action/publish)
id-token: write # for trusted publishing (changesets/action/publish)

jobs:
publish:
name: Publish
runs-on: ubuntu-latest
steps:
- name: Checkout repo
uses: actions/checkout@v4
uses: actions/checkout@v7
with:
persist-credentials: false # recommended: do not persist git credentials on disk

- name: Setup pnpm
uses: pnpm/action-setup@v4
with:
version: 9.6.0
uses: pnpm/setup@v2

- name: Setup node 24
uses: actions/setup-node@v4
uses: actions/setup-node@v7
with:
node-version: 24
cache: pnpm
package-manager-cache: false # recommended: avoid cache poisoning

- run: pnpm install

- name: Publish packages to npm
uses: changesets/action@v1
uses: changesets/action/publish@v2
with:
publish: pnpm changeset publish
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
script: pnpm changeset publish
21 changes: 11 additions & 10 deletions .github/workflows/version.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,31 +2,32 @@ name: version

on: workflow_dispatch

permissions:
contents: write # to check out repo (actions/checkout) and to create releases (changesets/action/publish)
pull-requests: write # to create pull request (changesets/action/version)

jobs:
version:
name: Version
runs-on: ubuntu-latest
steps:
- name: Checkout repo
uses: actions/checkout@v4
uses: actions/checkout@v7
with:
persist-credentials: false # recommended: do not persist git credentials on disk

- name: Setup pnpm
uses: pnpm/action-setup@v4
with:
version: 9.6.0
uses: pnpm/setup@v2

- name: Setup node 24
uses: actions/setup-node@v4
uses: actions/setup-node@v7
with:
node-version: 24
cache: pnpm
package-manager-cache: false # recommended: avoid cache poisoning

- run: pnpm install
- run: pnpm test
- run: pnpm format:check

- name: Create release PR
uses: changesets/action@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
uses: changesets/action/version@v2
2 changes: 1 addition & 1 deletion .prettierignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
.vscode/
pnpm-lock.yaml
pnpm-workspace.yaml
/packages/prettier-config/__fixtures__
/packages/prettier-config/__tests__/fixtures
5 changes: 2 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,9 @@
},
"devDependencies": {
"@changesets/cli": "^2.26.1",
"@types/jest": "^29",
"@trivago/prettier-plugin-sort-imports": "^6.0.2",
"enhanced-resolve": "^5.12.0",
"husky": "^9.0.11",
"jest": "~29.7.0",
"lint-staged": "^17.3.0",
"prettier": "^3.9.6",
"typescript": "^5.6.3"
Expand All @@ -21,5 +20,5 @@
"lint-staged": {
"*": "prettier --write --ignore-unknown"
},
"packageManager": "pnpm@9.6.0"
"packageManager": "pnpm@11.24.0"
}
92 changes: 0 additions & 92 deletions packages/eslint-config-expo/__tests__/index.test.js

This file was deleted.

94 changes: 94 additions & 0 deletions packages/eslint-config-expo/__tests__/index.test.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,94 @@
import { ESLint } from 'eslint'
import assert from 'node:assert/strict'
import { createRequire } from 'node:module'
import path from 'node:path'
import test from 'node:test'
import { fileURLToPath } from 'node:url'

const require = createRequire(import.meta.url)
const { lyraExpoConfig, reactCompilerRecommendedWarn } = require('../index.js')
const __dirname = path.dirname(fileURLToPath(import.meta.url))

function lintFiles(file) {
const eslint = new ESLint({
// Don't search for an eslint.config.js on disk; use the config below.
// (Loading it from disk would use dynamic import(), which Jest's VM rejects.)
overrideConfigFile: true,
baseConfig: [
...lyraExpoConfig,
...(file === 'file-with-recommended-warnings.ts' ? reactCompilerRecommendedWarn : []),
],
overrideConfig: {
settings: {
react: {
// forcing React version instead of "detect" because react is not installed locally
version: '18.2.0',
},
},
languageOptions: {
parserOptions: {
// Anchor type-aware linting to this package so projectService finds
// ../tsconfig.json regardless of where the tests are invoked from.
tsconfigRootDir: path.resolve(__dirname, '..'),
},
},
},
})

return eslint.lintFiles([`__tests__/fixtures/${file}`])
}

test('Validate ESLint configuration', async (t) => {
await t.test('[file-with-errors.js] should find errors', async () => {
const results = await lintFiles('file-with-errors.js')
assert.notEqual(results[0].warningCount, 0)
})

await t.test('[file-with-errors.ts] should find errors', async () => {
const results = await lintFiles('file-with-errors.ts')
assert.notEqual(results[0].warningCount, 0)
assert.strictEqual(results[0].errorCount, 0)
})

await t.test('[component-with-errors.tsx] should find errors', async () => {
const results = await lintFiles('component-with-errors.tsx')
assert.notEqual(results[0].warningCount, 0)
assert.notEqual(results[0].errorCount, 0)
})

await t.test('[file-with-type-errors.ts] should find deprecation warnings', async () => {
const results = await lintFiles('file-with-type-errors.ts')
const rules = results[0].messages.map((message) => message.ruleId)
assert.ok(rules.includes('@typescript-eslint/no-deprecated'))
assert.ok(!rules.includes('@typescript-eslint/no-floating-promises'))
assert.ok(!rules.includes('@typescript-eslint/no-misused-promises'))
})

await t.test(
'[file-with-recommended-warnings.ts] should apply the recommended preset',
async () => {
const results = await lintFiles('file-with-recommended-warnings.ts')
const rules = results[0].messages.map((message) => message.ruleId)
assert.ok(rules.includes('@typescript-eslint/no-explicit-any'))
assert.ok(rules.includes('@typescript-eslint/prefer-as-const'))
},
)

await t.test('[file-without-error.js] should not find any error', async () => {
const results = await lintFiles('file-without-error.js')
assert.strictEqual(results[0].warningCount, 0)
assert.strictEqual(results[0].errorCount, 0)
})

await t.test('[file-without-error.ts] should not find any error', async () => {
const results = await lintFiles('file-without-error.ts')
assert.strictEqual(results[0].warningCount, 0)
assert.strictEqual(results[0].errorCount, 0)
})

await t.test('[component-without-error.tsx] should not find any error', async () => {
const results = await lintFiles('component-without-error.tsx')
assert.strictEqual(results[0].warningCount, 0)
assert.strictEqual(results[0].errorCount, 0)
})
})
7 changes: 1 addition & 6 deletions packages/eslint-config-expo/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,7 @@
"url": "https://github.com/lyra/coding-style/issues"
},
"scripts": {
"test": "jest"
},
"jest": {
"testPathIgnorePatterns": [
"<rootDir>/__tests__/fixtures/"
]
"test": "node --test"
},
"dependencies": {
"@typescript-eslint/eslint-plugin": "^8.68.0",
Expand Down
44 changes: 44 additions & 0 deletions packages/eslint-config-node/__tests__/index.test.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
import { ESLint } from 'eslint'
import assert from 'node:assert/strict'
import test from 'node:test'

function lintFiles(file) {
const eslint = new ESLint({
overrideConfigFile: 'index.js',
overrideConfig: {
settings: {
react: {
// forcing React version instead of "detect" because package is not installed locally
version: '18.2.0',
},
},
},
})

return eslint.lintFiles([`__tests__/fixtures/${file}`])
}

test('Validate ESLint configuration', async (t) => {
await t.test('[fixture-with-errors.js] should find errors', async () => {
const results = await lintFiles('file-with-errors.js')
assert.notEqual(results[0].errorCount, 0)
})

await t.test('[fixture-with-errors.ts] should find errors', async () => {
const results = await lintFiles('file-with-errors.ts')
assert.notEqual(results[0].warningCount, 0)
assert.notEqual(results[0].errorCount, 0)
})

await t.test('[fixture-without-error.js] should not find any error', async () => {
const results = await lintFiles('file-without-error.js')
assert.strictEqual(results[0].warningCount, 0)
assert.strictEqual(results[0].errorCount, 0)
})

await t.test('[fixture-without-error.ts] should not find any error', async () => {
const results = await lintFiles('file-without-error.ts')
assert.strictEqual(results[0].warningCount, 0)
assert.strictEqual(results[0].errorCount, 0)
})
})
Loading