Repository navigation
feat: add opt-in native 1440p rendering to Kirby - #2164
Draft
xiaoyaodabing wants to merge 1 commit into
Draft
xiaoyaodabing wants to merge 1 commit into
xiaoyaodabing wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an opt-in native 2560×1440 mode to Kirby 1.0.0 on Mac. It increases the game canvas and scene render targets, including the matching half- and quarter-resolution targets. The HUD reports the presented game canvas and window size separately. The menu saves the choice and asks the player to relaunch when changing canvas size.
The patch checks the original words and available patch space before writing. Square shadow maps and movie source resolution retain their original sizes. Dynamic resolution and fixed 1080p remain available.
Validation
Why draft
A player reported pronounced ground shadow flicker in the opening forest at 1440p. I compared 24 consecutive game frames while idle and another 24 while walking forward at each resolution, with 60 FPS selected and the same save and opening scene. The idle captures showed no comparable large shadow jumps in either mode. Shadow boundaries moved in both walking captures, where the camera also moved. These short samples did not establish the cause of the reported flicker or rule out a rendering regression. Broader scene and Mac coverage is still needed.