Skip to content

feat: add language selection to Kirby on Mac - #2163

Open
xiaoyaodabing wants to merge 1 commit into
ly05010419:mainfrom
xiaoyaodabing:codex/kirby-language
Open

xiaoyaodabing wants to merge 1 commit into
ly05010419:mainfrom
xiaoyaodabing:codex/kirby-language

Conversation

@xiaoyaodabing

Copy link
Copy Markdown

Kirby on Mac now offers Follow System, Simplified Chinese, and English in Settings → Language. The runtime reads the saved choice at startup so the game and Mac menus switch together after a normal quit and relaunch. The choice uses the existing save directory, and explicit diagnostic language overrides still work.

Validation

  • Built and packaged Kirby 1.0.0 on Apple M1 Max, macOS 27.2. Signature verification and the launcher check passed.
  • With a copied profile, launched in Follow System (Chinese on this Mac), selected English and relaunched, then selected Simplified Chinese and relaunched. Verified the matching title screen and Mac menu in both languages and that File 1 was available in both.
  • All 22 Kirby tests passed, including language and override tests. The repository C checks and settings test group passed with the settings group's three skips.
  • The full source test group ran 1,466 tests. The archive timeout PID-file error and the existing Tears of the Kingdom work-folder assertion also reproduced on the unmodified base on this Mac.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant