Repository navigation
fix(oot): a Brazilian Portuguese Mac or app language plays Ocarina of Time in Brazilian Portuguese - #2161
Open
victormlourenco wants to merge 1 commit into
Open
fix(oot): a Brazilian Portuguese Mac or app language plays Ocarina of Time in Brazilian Portuguese#2161victormlourenco wants to merge 1 commit into
victormlourenco wants to merge 1 commit into
Conversation
… Time in Brazilian Portuguese desired_language passed brazil=0 for Ocarina of Time, so a pt-BR locale (the Mac's, or the app's own AppleLanguages) mapped to European "pt". The game's v131072 RomFS has the official Brazilian Portuguese text (1,719 files under USpt, next to USen and USes), as Tears of the Kingdom 1.4.3 and Breath of the Wild 1.9.0 do, so GAME_OOT now takes brazil=1 as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With the Mac's language, or the app's own language (
defaults write org.macnativegames.oot AppleLanguages -array pt-BR), set to Brazilian Portuguese, Ocarina of Time chose European Portuguese (pt).desired_languageingames/oot/runtime/services.cpassesbrazil=0togame_language()for every game except Tears of the Kingdom 1.4.3 and Breath of the Wild 1.9.0, sopt-BRbecamept.Fix
The v131072 RomFS has the official Brazilian Portuguese text:
assets/romfs-v131072.tsv.gzlists 1,719 files underUSpt, next toUSen(1,747) andUSes(1,715).GAME_OOTnow takesbrazil=1too, and the comment above the function names it. The change is in Ocarina of Time's ownruntime/services.conly; no other game is affected.Testing
update_runtime.py,AppleLanguagesoforg.macnativegames.ootset topt-BR. The game log has[totk] language: pt-BR (TOTK_LANG=- TOTK_LOCALE=pt-BR), and the game started in Brazilian Portuguese.