feat(cmd): add backup command - #99
Conversation
dc53498 to
48d9d7b
Compare
jochumdev
left a comment
There was a problem hiding this comment.
Nice work, thank you.
See the comments and please make sure that you inline every helper that is used only once or even twice.
|
Solid work! Thanks for resolving everything. Next thing is progress, I don't think we get the percentage from incus but we can a show a spinner per volume. I would like to add some more changes, we can squash those after, ok? |
|
Sure Squash at the end works. |
|
relock interval every 30 seconds |
|
Last commit looks damn great! Had no detailed look at it yet as I'm working on a healthd rewrite, will check later. |
45013c0 to
ed586b6
Compare
|
@jochumdev I am hitting a latent DNS watcher race: two processes with watchers on the same network (e.g. concurrent Full disclosure: I ran this through an AI to trace the root cause, and this is the output I got — my parallel backup test hits it. Would you treat those two errors as benign (or retry) in the watcher? |
|
Nice bug you found. I was never a friend of retry but recently I became friends with it, so go retry. It's ok to have that bugfix in this branch :) And about DNS in general, soon we will have |
e2ed74e to
ed586b6
Compare
Signed-off-by: Ishaan Jindal <ishaanjindal2006@gmail.com>
Signed-off-by: Ishaan Jindal <ishaanjindal2006@gmail.com>
Signed-off-by: Ishaan Jindal <ishaanjindal2006@gmail.com>
Signed-off-by: Ishaan Jindal <ishaanjindal2006@gmail.com>
Signed-off-by: Ishaan Jindal <ishaanjindal2006@gmail.com>
Signed-off-by: Ishaan Jindal <ishaanjindal2006@gmail.com>
Signed-off-by: Ishaan Jindal <ishaanjindal2006@gmail.com>
Signed-off-by: Ishaan Jindal <ishaanjindal2006@gmail.com>
Signed-off-by: Ishaan Jindal <ishaanjindal2006@gmail.com>
Signed-off-by: René Jochum <rene@jochum.dev>
|
Done on the update. Integrated your logic as an "Action", using one file per run. |
Would close #45