nic: allow create-path NIC devices with nictype and no managed network - #134
Merged
Merged
Conversation
toNicDevice() unconditionally required a managed `network:` (via Config.Network or Config.NetworkName), even though Extensions already carries everything an unmanaged-bridge NIC device needs (nictype + parent). Incus itself accepts this device shape directly -- the validation here was stricter than the daemon it targets. Only reject when neither a managed network nor `nictype` is present, matching Incus's own two valid ways to declare a NIC. network: is also no longer forced into the device map when unset, so `nictype` based devices don't pick up an empty network="" key. Adds TestNicDevices (regression case fails against the prior code with the exact reported error, "bad config for device eth1") and a narrow- scoping error case confirming an unrelated extension alone still errors. Signed-off-by: Andrey P <andrey@rpi5.local>
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toNicDevice() unconditionally required a managed
network:(via Config.Network or Config.NetworkName), even though Extensions already carries everything an unmanaged-bridge NIC device needs (nictype + parent). Incus itself accepts this device shape directly -- the validation here was stricter than the daemon it targets.Only reject when neither a managed network nor
nictypeis present, matching Incus's own two valid ways to declare a NIC. network: is also no longer forced into the device map when unset, sonictypebased devices don't pick up an empty network="" key.Adds TestNicDevices (regression case fails against the prior code with the exact reported error, "bad config for device eth1") and a narrow- scoping error case confirming an unrelated extension alone still errors.