Skip to content

[WRONG BRANCH] fix: pin combo response child routes to concrete targets to avoid alias shadowing - #94

Closed
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-alias-collision-vulnerability
Closed

[WRONG BRANCH] fix: pin combo response child routes to concrete targets to avoid alias shadowing#94
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-alias-collision-vulnerability

Conversation

@luvs01

@luvs01 luvs01 commented Aug 8, 2026

Copy link
Copy Markdown
Owner

Motivation

  • Public combo aliases could be re-resolved for already-selected concrete combo targets, allowing a shadowing alias to redirect child requests to an unintended provider/model and leak prompt payloads.
  • routeModelInternal already had a bypass for concrete targets, but the combo child dispatch path still used the alias-aware public routeModel() and thus re-entered alias resolution.

Description

  • Add routeConcreteModel(config, modelId) in src/router.ts that calls the internal resolver with bypassCombos=true to resolve a concrete provider/model without consulting public combo aliases.
  • Use routeConcreteModel() in src/server/responses/core.ts for combo child checks and when building the child request (canDecryptUnreadableAgentTask, targetRoute, and child-request routing), ensuring child payloads remain pinned to the originally selected physical target.
  • Make handleResponses call the concrete resolver for recursive combo child attempts by checking options.comboAttempt so alias-aware routing is disabled for those recursive invocations.
  • Add an end-to-end regression test in tests/server-combo-failover-e2e.test.ts that verifies a shadowing combo alias cannot redirect a child request away from the selected concrete provider.

Testing

  • Ran bun run typecheck (via PATH="$PWD/node_modules/.bin:$PATH" bun run typecheck) and it succeeded.
  • Ran the targeted test: ./node_modules/.bin/bun test tests/server-combo-failover-e2e.test.ts --filter "dispatches a selected concrete target" and it passed.
  • Ran bun run privacy:scan and it passed.
  • Attempted the full bun run test; the changes are localized and the focused combo failover suite passed, but the full-suite run encountered unrelated environment-specific failures/timeouts in this container (these are unrelated to the combo routing change).

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 40 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ee761d64-d494-448f-aef7-f57dbf6ed54d

📥 Commits

Reviewing files that changed from the base of the PR and between 726e1c7 and cda3f76.

📒 Files selected for processing (3)
  • src/router.ts
  • src/server/responses/core.ts
  • tests/server-combo-failover-e2e.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot changed the title fix: pin combo response child routes to concrete targets to avoid alias shadowing [WRONG BRANCH] fix: pin combo response child routes to concrete targets to avoid alias shadowing Aug 8, 2026
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions
github-actions Bot marked this pull request as draft August 8, 2026 06:55
@github-actions github-actions Bot added the bug Something isn't working label Aug 8, 2026
@luvs01 luvs01 closed this Aug 9, 2026
@luvs01 luvs01 reopened this Aug 19, 2026
@luvs01 luvs01 closed this Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant