Skip to content

[WRONG BRANCH] fix(grok): harden managed fence parsing - #89

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-grok-config-managed-block-vulnerability
Draft

[WRONG BRANCH] fix(grok): harden managed fence parsing#89
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-grok-config-managed-block-vulnerability

Conversation

@luvs01

@luvs01 luvs01 commented Aug 8, 2026

Copy link
Copy Markdown
Owner

Motivation

  • Untrusted provider-discovered model IDs could contain the Grok managed-block marker text and confuse the naive substring-based fence detection, leaving stale attacker-influenced TOML behind and corrupting ~/.grok/config.toml.

Description

  • Require the BEGIN/END markers to appear as marker-only comment lines by matching them with a line-anchored regular expression in findManagedRegion, so marker substrings inside TOML values are ignored. (Changes in src/grok/inject.ts.)
  • Use a safely-escaped marker regex and compute the matched begin/end positions so replacements and removals operate on true fence boundaries only. (Changes in src/grok/inject.ts.)
  • Add a regression test that injects a hostile model id containing both marker strings and verifies injectGrokConfig/stripGrokConfig preserve valid TOML and fully remove the managed block during replace/cleanup. (Changes in tests/grok-config-inject.test.ts.)

Testing

  • Ran ./node_modules/.bin/bun test tests/grok-config-inject.test.ts and the focused Grok tests passed (44 tests).
  • Ran ./node_modules/.bin/bun run typecheck and ./node_modules/.bin/bun run privacy:scan, both of which succeeded.
  • Ran git diff --check to validate no leftover whitespace changes and committed the patch; the commit is shown as fix(grok): match managed markers only on fence lines.
  • Note: a prior run of the broader bun run test experienced unrelated timeouts in long-running native-profile concurrency/provider-management tests while debugging the environment; the focused Grok regression and CI-required checks above are green.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 58 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ed44735d-552b-4083-acd0-620ac2ad4612

📥 Commits

Reviewing files that changed from the base of the PR and between e3b2d6e and b086743.

📒 Files selected for processing (2)
  • src/grok/inject.ts
  • tests/grok-config-inject.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 8, 2026
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions github-actions Bot changed the title fix(grok): harden managed fence parsing [WRONG BRANCH] fix(grok): harden managed fence parsing Aug 8, 2026
@github-actions
github-actions Bot marked this pull request as draft August 8, 2026 06:38
@luvs01 luvs01 closed this Aug 19, 2026
@luvs01 luvs01 reopened this Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant