[WRONG BRANCH] fix(cursor): bind ref-less prefix checkpoints to conversation id - #325
Draft
luvs01 wants to merge 1 commit into
Draft
[WRONG BRANCH] fix(cursor): bind ref-less prefix checkpoints to conversation id#325luvs01 wants to merge 1 commit into
luvs01 wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
conversationIdto match the active request before accepting a ref-less prefix match by adding aconversationIdparameter togetCursorCheckpointForPrefixand checking it during lookup (src/adapters/cursor/checkpoint-store.ts).request.conversationIdinto the prefix lookup path and keep the conversation-lineage gate after resolution (src/adapters/cursor/request-builder.ts).src/adapters/cursor/request-builder.ts).tests/cursor-request-builder.test.ts).Testing
bun test tests/cursor-request-builder.test.ts— all tests passed (44 passed, 0 failed).bun run typecheck— success;bun run privacy:scan— success.bun run test— the changed Cursor-focused tests passed within the full run, but the complete suite reported unrelated failures in other subsystems (environment/service/timing-sensitive tests); these failures are outside the Cursor changes and were not caused by this fix.Codex Task