[WRONG BRANCH] fix(responses): bound retained tool-search item IDs - #323
Closed
luvs01 wants to merge 1 commit into
Closed
[WRONG BRANCH] fix(responses): bound retained tool-search item IDs#323luvs01 wants to merge 1 commit into
luvs01 wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
output_item.doneso trailingfunction_call_arguments.*frames remain suppressed for routedtool_searchitems instead of leaking to the client.Description
MAX_CLASSIFIED_ITEM_IDSandMAX_CLASSIFIED_ITEM_ID_BYTES, trackclassifiedItemIdBytes, and fail closed when those caps are exceeded viaTranslatorBudgetExceededError.item_idskind and release those charges fromreleaseAll, overflow cleanup, and the ordinary-id clear path.classifyItemIdandclearOrdinaryItemIdshelpers and replace ad-hoc Set mutations with budgeted, bounded classification logic while preserving the late-frame suppression behavior.Testing
bun run test -- tests/responses-tool-search-repair.test.ts, which passed all tests in that file.bun x tsc --noEmit/bun run typecheckandbun run privacy:scan, both of which completed successfully.bun run test, which was exercised but encountered an unrelated preexisting failure intests/server-auth.test.ts(received HTTP 403 where the test expected 401), so the full-suite run was not used as a blocker for this focused fix.Codex Task