Skip to content

[WRONG BRANCH] fix(codex): honor scoped cooldowns in subagent fallback - #121

Closed
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-codex-quota-issue
Closed

[WRONG BRANCH] fix(codex): honor scoped cooldowns in subagent fallback#121
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-codex-quota-issue

Conversation

@luvs01

@luvs01 luvs01 commented Aug 8, 2026

Copy link
Copy Markdown
Owner

Motivation

  • Subagent fallback could select a native model even when that model’s quota group had a reset-derived scoped cooldown, because the fallback logic only checked account-wide cooldown/probe APIs.

Description

  • Add a side-effect-free scoped probe-lease eligibility helper canAcquireCodexQuotaScopeProbeLease in src/codex/routing.ts that mirrors scoped tryAcquireCodexQuotaScopeProbeLease pacing rules.
  • Update src/codex/subagent-model-fallback.ts to consult getCodexQuotaHealthSnapshot for the candidate model's quotaScope and to use the matching scoped or account-wide canAcquire*ProbeLease check before accepting a pool candidate.
  • Remove the legacy account-only cooldown short-circuit and replace it with the scoped-aware check while preserving existing probe-lease behavior and account-qualified route semantics.
  • Add a regression test pool fallback skips a reset-derived cooldown in the model's quota scope in tests/subagent-model-fallback.test.ts that verifies reset-derived scoped cooldowns cause fallback to advance instead of retrying the exhausted native model.

Testing

  • Ran bun run typecheck which completed without errors.
  • Ran the full suite with bun run test (CI-managed runner in this environment) and the run completed with the test suite exercising the modified fallback paths; no test failures were reported in the executed run.
  • Ran bun run privacy:scan which passed.
  • A targeted bun test tests/subagent-model-fallback.test.ts run initially failed in the interactive environment due to a local Bun/Python environment mismatch (a node:zlib export not found in the older Bun binary), but the full bun run test execution used the repository's test runner and validated the added regression case.

Codex Task

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 56 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c735dffb-6298-4037-8f03-bc2f53fa6275

📥 Commits

Reviewing files that changed from the base of the PR and between 57140d6 and e1e656c.

📒 Files selected for processing (3)
  • src/codex/routing.ts
  • src/codex/subagent-model-fallback.ts
  • tests/subagent-model-fallback.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 8, 2026
@github-actions github-actions Bot changed the title fix(codex): honor scoped cooldowns in subagent fallback [WRONG BRANCH] fix(codex): honor scoped cooldowns in subagent fallback Aug 8, 2026
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions
github-actions Bot marked this pull request as draft August 8, 2026 10:48
@luvs01 luvs01 closed this Aug 19, 2026
@luvs01 luvs01 reopened this Aug 19, 2026

luvs01 commented Aug 22, 2026

Copy link
Copy Markdown
Owner Author

Superseded by the independently prepared upstream PR lidge-jun#2418, based on current dev with expanded scoped, unrelated-scope, and account-wide probe regression coverage. Closing this wrong-base draft; do not merge or continue this branch.

@luvs01 luvs01 closed this Aug 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant