perf: add skip_reference_registration to all XMI model classes#86
Merged
Conversation
Eliminates ~76K useless Store registrations during XMI parsing. WeakRef/Store overhead was consuming 32-70% of total CPU time. Class instance variables don't inherit, so every Serializable subclass needs skip_reference_registration explicitly. Also regenerate .rubocop_todo.yml after adding to 92 source files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminates ~76K useless Store registrations during XMI parsing.
StackProf profiling showed WeakRef/Store overhead consuming 32-70% of total CPU time. This adds
skip_reference_registrationto everyLutaml::Model::Serializablesubclass in the XMI gem.Ruby class instance variables don't inherit — every subclass needs the declaration explicitly, including indirect inheritance chains like
UpperValue < DefaultValue,Sparx::Root < ::Xmi::Root, etc.92 source files modified + regenerated
.rubocop_todo.yml.All 299 specs pass (4 pending performance benchmarks that need PERF_CHECK env var).