Skip to content

Resolve include directives for Rng.parse_rnc#27

Open
HassanAkbar wants to merge 4 commits into
mainfrom
parse-rnc-with-includes
Open

Resolve include directives for Rng.parse_rnc#27
HassanAkbar wants to merge 4 commits into
mainfrom
parse-rnc-with-includes

Conversation

@HassanAkbar

Copy link
Copy Markdown
Member

fixes #26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the in-memory RNC parsing entry point (Rng.parse_rnc) to resolve include directives when a location is provided, bringing it in line with Rng.parse_file and addressing issue #26.

Changes:

  • Route RncParser.parse / Rng.parse_rnc through IncludeProcessor#parse_content as the canonical parsing pipeline.
  • Extend IncludeProcessor to optionally resolve includes for in-memory content when location is provided.
  • Add specs to validate include resolution parity between parse_rnc(..., location: ...) and parse_file.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
spec/rng/schema_spec.rb Adds integration-style specs for include resolution from in-memory RNC.
spec/rng/parse_rnc_spec.rb Adds focused unit specs for .parse_rnc behavior with/without location.
lib/rng/rnc_parser.rb Delegates parse to IncludeProcessor to centralize parsing behavior.
lib/rng/parse_rnc.rb Removes the old placeholder wrapper implementation.
lib/rng/include_processor.rb Adds parse_content and refactors include resolution flow for in-memory parsing.
lib/rng.rb Adds Rng.parse_rnc(rnc, location: nil) entry point using IncludeProcessor.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/rng/include_processor.rb
Comment thread spec/rng/schema_spec.rb Outdated
Comment thread spec/rng/schema_spec.rb Outdated
Comment thread spec/rng/parse_rnc_spec.rb
@HassanAkbar HassanAkbar requested a review from ronaldtse June 8, 2026 14:37
@HassanAkbar HassanAkbar marked this pull request as ready for review June 9, 2026 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rng.parse_rnc(text) does not resolve include directives

2 participants