Resolve include directives for Rng.parse_rnc#27
Open
HassanAkbar wants to merge 4 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the in-memory RNC parsing entry point (Rng.parse_rnc) to resolve include directives when a location is provided, bringing it in line with Rng.parse_file and addressing issue #26.
Changes:
- Route
RncParser.parse/Rng.parse_rncthroughIncludeProcessor#parse_contentas the canonical parsing pipeline. - Extend
IncludeProcessorto optionally resolve includes for in-memory content whenlocationis provided. - Add specs to validate include resolution parity between
parse_rnc(..., location: ...)andparse_file.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| spec/rng/schema_spec.rb | Adds integration-style specs for include resolution from in-memory RNC. |
| spec/rng/parse_rnc_spec.rb | Adds focused unit specs for .parse_rnc behavior with/without location. |
| lib/rng/rnc_parser.rb | Delegates parse to IncludeProcessor to centralize parsing behavior. |
| lib/rng/parse_rnc.rb | Removes the old placeholder wrapper implementation. |
| lib/rng/include_processor.rb | Adds parse_content and refactors include resolution flow for in-memory parsing. |
| lib/rng.rb | Adds Rng.parse_rnc(rnc, location: nil) entry point using IncludeProcessor. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #26