fix: strip whitespace from YAML string before parsing#88
Open
opoudjis wants to merge 1 commit into
Open
Conversation
FormatDetector.detect_string_uncached applies str.strip before checking
trimmed.start_with?("---"), but YamlComparator.parse_yaml passes the raw
unstripped string to YAML.safe_load. This inconsistency means a string
can be auto-detected as valid YAML but then fail to parse — e.g. a
heredoc with leading whitespace before "---".
This is especially relevant for the new be_equivalent_to matcher
(introduced in 0.2.0) which auto-detects format and commonly receives
heredoc strings with leading/trailing whitespace.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan