Added toy example and bare bones structure#3
Open
shiningsurya wants to merge 11 commits into
Open
Conversation
Owner
|
Thank you Surya. This pull request shows one good illustration that how ADX should work on one case. I think it is the time to make a simplifed and abstract frame work. Since this pull request has been diverage from the master too much. I will make a new master based on your branch and decision we made in the telecon. You can rebase from the new one. |
Collaborator
|
Are you going to do that now or wait for our meeting so we can talk it over?
…On April 4, 2019 at 4:39:35 PM, Jing Luo ***@***.***) wrote:
Thank you Surya. This pull request shows one good illustration that how
ADX should work on one case. I think it is the time to make a simplifed and
abstract frame work. Since this pull request has been diverage from the
master too much. I will make a new master based on your branch and decision
we made in the telecon. You can rebase from the new one.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABdtPPzMVsD_i_vp9J5m_aqflaNMf3pBks5vdnEXgaJpZM4bGjpW>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi