fix(core): reconcile order line refunded quantity - #2710
Open
tazzytazzy wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2709.
Adds a guarded core migration to reconcile
order_lines.refunded_quantityon existing Lunar 2.x databases.The line-item refund work added this column to the order-lines create-table
baseline. Databases that had already recorded that migration did not rerun it,
so they could receive
refund_lineswhile still lacking the rollup column.When those databases processed a line-item refund, Lunar could complete the
payment driver's refund call and then fail while persisting the line allocation
because
RefundOrderincrements the missing column.Changes
refund_lines;refunded_quantitycolumn with a default of0;Tests
Scope
This PR is limited to Lunar's provider-independent schema reconciliation. It
does not change provider behavior, refund transaction boundaries, ledger
attribution, replay semantics,
RefundRequest, or historical allocation data.