Add flat-rate and free-shipping options to table-rate shipping method drivers (#2617) - #2658
Open
wakqasahmed wants to merge 2 commits into
Open
Add flat-rate and free-shipping options to table-rate shipping method drivers (#2617)#2658wakqasahmed wants to merge 2 commits into
wakqasahmed wants to merge 2 commits into
Conversation
…ons and translations (lunarphp#2617)
… options for shipping methods (lunarphp#2617) - add flat-rate/free-shipping translations to remaining locales (ar, bg, fa, hr, mn) - source shipping method driver select options from Shipping::getSupportedDrivers() instead of a hardcoded list, so extended drivers become selectable automatically - add a locale-parity test asserting every shippingmethod.php locale file exposes the same driver option keys
glennjacobs
marked this pull request as draft
August 27, 2026 13:47
glennjacobs
marked this pull request as ready for review
August 27, 2026 13:47
glennjacobs
marked this pull request as draft
August 27, 2026 13:53
glennjacobs
marked this pull request as ready for review
August 27, 2026 13:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The table-rate-shipping method picker in Filament only listed two of the four registered shipping drivers (
ShipByandCollection), soFlatRateandFreeShippingweren't selectable even though both drivers exist and work fine once assigned some other way. Closes #2617.The Filament resource now builds its options from
Shipping::getSupportedDrivers()instead of a hardcoded list, so any driver registered viaShipping::extend()shows up automatically going forward. Added translations forflat-rate/free-shippingacross all 14 shipped locales (a few had been missed in an earlier pass), and a test that asserts every locale'sshippingmethod.phpexposes the same driver-option keys, so a future locale gap fails CI instead of silently falling back to English.Couldn't run the suite locally (no PHP in this environment), so I read through
ShippingManagerand the built-in drivers carefully to confirm none of them have side effects on instantiation before switching the form options to build from the manager dynamically.