You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Windows builds could invoke Visual Studio’s bundled CMake (4.x) during vcpkg dependency builds, even when workflows had already installed/pinned CMake via lukka/get-cmake. This came from the default runVcpkgEnvFormatString including --tools, which can reorder PATH toward toolchain-provided binaries.
Default behavior change (action input)
Updated runVcpkgEnvFormatString default in action.yml to remove --tools.
Result: vcpkg env no longer prefers VS-integrated CMake by default; CMake already on PATH (e.g. from get-cmake) remains preferred.
Documentation clarity
Added README note explaining the new default and why.
Documented opt-in path for users who still want --tools via explicit runVcpkgEnvFormatString.
Regression guard
Added a focused unit assertion ensuring the default string does not reintroduce --tools.
@copilot Instead of changing the existing behavior, why not simply document how to omit the --tools flag so that tool paths are not added to the PATH environment variable.
@copilot Instead of changing the existing behavior, why not simply document how to omit the --tools flag so that tool paths are not added to the PATH environment variable.
Implemented in 33b98df: restored the original default (keeps --tools) and updated the README to document how to omit --tools by setting a custom runVcpkgEnvFormatString.
@copilot Instead of changing the existing behavior, why not simply document how to omit the --tools flag so that tool paths are not added to the PATH environment variable.
Implemented in 33b98df: restored the original default (keeps --tools) and updated the README to document how to omit --tools by setting a custom runVcpkgEnvFormatString.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows builds could invoke Visual Studio’s bundled CMake (4.x) during
vcpkgdependency builds, even when workflows had already installed/pinned CMake vialukka/get-cmake. This came from the defaultrunVcpkgEnvFormatStringincluding--tools, which can reorder PATH toward toolchain-provided binaries.Default behavior change (action input)
runVcpkgEnvFormatStringdefault inaction.ymlto remove--tools.vcpkg envno longer prefers VS-integrated CMake by default; CMake already on PATH (e.g. fromget-cmake) remains preferred.Documentation clarity
--toolsvia explicitrunVcpkgEnvFormatString.Regression guard
--tools.