AI-written fix to crypto-rng TypeError in recent NodeJS#20
Open
resonant-riches wants to merge 1 commit intolukebuehler:mainfrom
Open
AI-written fix to crypto-rng TypeError in recent NodeJS#20resonant-riches wants to merge 1 commit intolukebuehler:mainfrom
resonant-riches wants to merge 1 commit intolukebuehler:mainfrom
Conversation
The up8-ticket dependency was calling crypto.rng() which doesn't exist in Node.js (it has crypto.randomBytes() instead). This caused network-key generation commands to fail with "TypeError: crypto.rng is not a function". Applied a patch using patch-package that adds crypto.rng as an alias to crypto.randomBytes in the up8-ticket module. This fix is automatically applied on npm install via the postinstall script. Also removed redundant workarounds from network-key.js, wallet.js, and cli.js that were incomplete. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully fixes #17
Written by Claude Code because I don't understand NodeJS well enough to do it myself.
Claude's comments below:
The up8-ticket dependency was calling crypto.rng() which doesn't exist in Node.js (it has crypto.randomBytes() instead). This caused network-key generation commands to fail with "TypeError: crypto.rng is not a function".
Applied a patch using patch-package that adds crypto.rng as an alias to crypto.randomBytes in the up8-ticket module. This fix is automatically applied on npm install via the postinstall script.
Also removed redundant workarounds from network-key.js, wallet.js, and cli.js that were incomplete.