Merged
Conversation
Owner
|
This change is going to break a lot of existing implementation and usages, as you can see from the amount of test you need to change. This shouldn't be done. Non breakable way is to introduce a new protected virtual method that would return the fields for mapping, so that the code looks like Then the if someone wants to play around with that collection they can override that method and do |
Contributor
Author
|
Refactored and written a filter that treats a datetime property as dateonly for the purpose of comparison |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an Action parameter to Filter in Entity.cs to allow for greater control of what happens to the DB query.