Skip to content

Add bulk trade support#842

Merged
luciensadi merged 2 commits intoluciensadi:masterfrom
max-buzzkill:feature/bulk_trade_syntax
Mar 19, 2026
Merged

Add bulk trade support#842
luciensadi merged 2 commits intoluciensadi:masterfrom
max-buzzkill:feature/bulk_trade_syntax

Conversation

@max-buzzkill
Copy link
Contributor

Add support for trading in more than 1 karma for nuyen (and the reverse, if ALLOW_TRADING_NUYEN_FOR_KARMA is set)

  • [amount] <karma|nuyen> [confirm] syntax
  • current trade karma syntax will continue to trade 1 karma without confirmation
  • trading n > 1 karma requires confirmation similar to addpoint
  • trading n > karma without confirm displays the expected number of yen gained, and a prompt to confirm

Tested locally up to 10k karma traded at once with no noticeable spikes in cpu. Structured in such a way as to make it trivial to add a max either globally or on a per-keyword basis if need be.

Copy link
Owner

@luciensadi luciensadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch! Had a few thoughts

@max-buzzkill
Copy link
Contributor Author

Updated with requested changes

@luciensadi
Copy link
Owner

LGTM, thanks for the patch!

@luciensadi luciensadi merged commit 8393cf7 into luciensadi:master Mar 19, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants