feat: global GPG keyring with interactive picker#21
Merged
Conversation
- Re-canonicalize path on load for defense-in-depth - Add trailing newline to config file - Use RAII guard for env var mutation in unit tests (safety)
lucatescari
force-pushed
the
feat/global-gpg-keyring
branch
from
dcca3cd to
0651efc
Compare
- Unit tests: add Mutex to serialize env var mutations (fixes macOS CI race) - GPG test: set GNUPGHOME to empty temp dir so GPG fails fast on all platforms instead of hanging (restores test on Windows)
- New tests/gpg_integration.rs: real GPG operations with temp keyrings - add-gpg-user: by email, fingerprint, --trusted, --no-commit, -k, --from - rm-gpg-user: remove, --no-commit, user not found error - ls-gpg-users: list, no users, named key - GPG unlock roundtrip: add user -> lock -> unlock via GPG - Multi-user: add 2, remove 1, verify count - All tests auto-skip if GPG unavailable (skip_without_gpg! macro) - CI: install GPG on Linux/macOS, run gpg_integration test step - CLAUDE.md: add mandatory testing policy for all commands/features - Total: 91 tests (31 unit + 40 integration + 14 GPG + 6 cross-compat)
gpg_available() now tests that GPG can operate with a custom GNUPGHOME, not just that the binary exists. On Windows CI, Git's bundled GPG reports a version but fails with MSYS2 path translation errors.
Gpg4win handles native Windows paths correctly, unlike the GPG bundled with Git for Windows (which fails with MSYS2 path issues). This enables GPG integration tests to run on all 3 platforms.
lucatescari
added a commit
that referenced
this pull request
Apr 15, 2026
feat: global GPG keyring with interactive picker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gitveil config set-keyring/unset-keyring/showcommands for managing a global GPG keyring directorygitveil add-gpg-user(no args, no--from) now falls back to scanning the configured keyring directory with an interactive picker~/.config/gitveil/configwith 0o600/0o700 permissionsSecurity
Test plan
#[cfg(unix)]cargo clippy --all-targets -- -D warningscleancargo fmt --checkclean🤖 Generated with claude-flow