fix(types): allow partial weights object - #295
Open
aleclarson wants to merge 1 commit into
Open
Conversation
Owner
|
Hi @aleclarson , thanks for your contribution! This is a good change, but at the moment the tests are failing due to this typing error: If you can fix it, I am happy to merge your pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the type of
SearchOptions.weightsto allow partial definition.I also added
@defaultcomments for each weight type, to give users a baseline value to tweak in experiments.Finally, I changed how the default weights are merged into the user-provided weights, ensuring that an explicit
undefinedvalue in the user-provided weights doesn‘t prevent the default weight from being used.