target: add -Zunstable-options when querying cfg#537
Open
DeepeshWR wants to merge 1 commit intolu-zero:masterfrom
Open
target: add -Zunstable-options when querying cfg#537DeepeshWR wants to merge 1 commit intolu-zero:masterfrom
DeepeshWR wants to merge 1 commit intolu-zero:masterfrom
Conversation
Owner
|
Can you please also add a test for it? |
Owner
|
adding it unconditionally breaks everything though :) |
DeepeshWR
force-pushed
the
fix/custom-target-cfg-unstable-options
branch
from
4de8265 to
f18c870
Compare
Owner
|
Please make rustfmt and clippy happy |
DeepeshWR
force-pushed
the
fix/custom-target-cfg-unstable-options
branch
from
f18c870 to
bb234d1
Compare
Owner
|
it is still unhappy :/ |
DeepeshWR
force-pushed
the
fix/custom-target-cfg-unstable-options
branch
from
bb234d1 to
bce4107
Compare
Author
Fixed now :) |
Owner
|
sadly not yet... |
Since Rust 1.95,invoking rustc with `--target` requires `-Zunstable-options` when used with custom JSON targets. Without this flag, the command fails. Reference: rust-lang/rust@b4e645f rust-lang/rust@8563312 Signed-off-by: Deepesh Varatharajan <Deepesh.Varatharajan@windriver.com>
lu-zero
force-pushed
the
fix/custom-target-cfg-unstable-options
branch
from
bce4107 to
b8049a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Rust 1.95,invoking rustc with
--targetrequires-Zunstable-optionswhen used with custom JSON targets. Without this flag, the command fails.Reference:
rust-lang/rust@b4e645f rust-lang/rust@8563312