Repository navigation
🐛 Retry the release PR lookup and fall back to the merge subject - #19
Merged
Merged
Conversation
The commit -> PR endpoint answered empty 500s for 5261d2d (#18's merge) on four attempts in a row, so the release step failed and v1 never moved. Retry each API call, fall back to the PR number in the merge commit's subject once the PR confirms it merged as that commit, and fail loudly instead of skipping the release when the lookup itself failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Release run for #18's merge commit (
5261d2d) failed on all four attempts (run 39801679511). Each time,GET /repos/ltetzlaff/swift/commits/5261d2d…/pullsreturned an emptyHTTP 500, andghreportedunexpected end of JSON input. Run locally, the same call alternated between 500 and 200. As a result,v1.8.0was never released andv1still points ata3177b5(Swift 6.3.3).Changes (
Find the merged PR and its version label)gh apicall is retried up to 5 times, waiting 10s, 20s, … between attempts.Merge pull request #N from …). It uses that number only afterGET /pulls/Nconfirms the PR merged intomainwith this exactmerge_commit_sha.Tested the step locally (with
trstanding in for bash 4's${LABELS,,}):5261d2d:PR #18 → minor5261d2d: five warnings, then the fallback givesPR #18 → minor::error::Could not look up the PR …Why this PR is labelled
minor#18 (the Swift 6.4.1 default, a
minorchange) was never released. Merging this PR runs Release again. The notes cover every commit sincev1.7.4, so this PR's label decides the version:minorgivesv1.8.0, which includes the 6.4.1 update, and movesv1to it.