Skip to content

DM-54912: Add photometric_scaling component to VisitImage.#1372

Merged
TallJimbo merged 1 commit into
mainfrom
tickets/DM-54912
May 19, 2026
Merged

DM-54912: Add photometric_scaling component to VisitImage.#1372
TallJimbo merged 1 commit into
mainfrom
tickets/DM-54912

Conversation

@TallJimbo
Copy link
Copy Markdown
Member

@TallJimbo TallJimbo commented May 15, 2026

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes
  • (if changing dimensions.yaml) make a copy of the updated dimensions.yaml in configs/old_dimensions and update the list in doc/lsst.daf.butler/dimensions.rst

@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.61%. Comparing base (c792fb9) to head (1463cbe).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1372   +/-   ##
=======================================
  Coverage   89.61%   89.61%           
=======================================
  Files         373      373           
  Lines       50776    50776           
  Branches     5913     5913           
=======================================
  Hits        45505    45505           
  Misses       3880     3880           
  Partials     1391     1391           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ObservationSummaryStats:
pytype: lsst.images.ObservationSummaryStats
ImageField:
pytype: lsst.images.fields.BaseField
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as other branch, I am not a fan of this name unless I am not understanding it.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we covered this on the other PR, but there was a misunderstanding: this storage class is for an arbitrary lsst.images.fields.Field, not anything specific to photometric scaling. It's possible it's still not a great name ("field" is heavily overloaded in some contexts), but I'm not going to try to change it on this ticket. I'm compiling a list of things to bring to #dm-naming-things and will include it there.

@TallJimbo TallJimbo merged commit 92b2eb9 into main May 19, 2026
26 of 27 checks passed
@TallJimbo TallJimbo deleted the tickets/DM-54912 branch May 19, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants