DM-54912: Add photometric_scaling component to VisitImage.#1372
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1372 +/- ##
=======================================
Coverage 89.61% 89.61%
=======================================
Files 373 373
Lines 50776 50776
Branches 5913 5913
=======================================
Hits 45505 45505
Misses 3880 3880
Partials 1391 1391 ☔ View full report in Codecov by Sentry. |
| ObservationSummaryStats: | ||
| pytype: lsst.images.ObservationSummaryStats | ||
| ImageField: | ||
| pytype: lsst.images.fields.BaseField |
There was a problem hiding this comment.
Same comment as other branch, I am not a fan of this name unless I am not understanding it.
There was a problem hiding this comment.
I think we covered this on the other PR, but there was a misunderstanding: this storage class is for an arbitrary lsst.images.fields.Field, not anything specific to photometric scaling. It's possible it's still not a great name ("field" is heavily overloaded in some contexts), but I'm not going to try to change it on this ticket. I'm compiling a list of things to bring to #dm-naming-things and will include it there.
81a7030 to
1463cbe
Compare
Checklist
doc/changesconfigs/old_dimensionsand update the list indoc/lsst.daf.butler/dimensions.rst