Implementing a method for unregistering modules#6
Open
tomasperezv wants to merge 1 commit intolrsjng:masterfrom
Open
Implementing a method for unregistering modules#6tomasperezv wants to merge 1 commit intolrsjng:masterfrom
tomasperezv wants to merge 1 commit intolrsjng:masterfrom
Conversation
0bf9503 to
70f7417
Compare
Author
|
Hi @lrsjng, I've updated this PR's code in order to be compatible with your latest changes. Would be great to get some feedback and/or discuss implementation details in case there is something you would like me to change in order to be able to merge this PR. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
This PR adds a new method to the modulejs interface in order to be able to unregister modules.
Why
Unregistering modules can be useful in some specific scenarios for instance for testing. We could, of course, modify directly the
_private.definitionsvariable, as explained in #2. However it's a bit cleaner if we can avoid accessing to the private values externally. Also this way we can include some logic in order to verify if the module is defined, etc.How
I've added the
unregistermethod, expose it, and implemented corresponding unit tests. I've also run the different check scripts.I've tried to follow the coding style defined in the library, I'm of course very open to feedback and comments.
Note: I haven't added the built distribution files since I wanted to hear your feedback first. If you agree with this PR I can do push them and increase the version number in the
package.json, or if you prefer you can do it.