Uma achiloc1 by utakbhate0943-dot · Pull Request #47 · lramos0/TheHiringCafe

utakbhate0943-dot · 2025-12-09T23:18:11Z

No description provided.

netlify · 2025-12-09T23:18:15Z

✅ Deploy Preview for mewannajob ready!

Name	Link
🔨 Latest commit	`aa5aabf`
🔍 Latest deploy log	https://app.netlify.com/projects/mewannajob/deploys/6938f66ddf1b5e0008c13891
😎 Deploy Preview	https://deploy-preview-47--mewannajob.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot

Pull request overview

This PR refactors text extraction logic from script.js into separate modular files under web/model/parsing/, improving code organization and maintainability. The changes extract three major functions (extractLocation, extractEducation, and extractAchievements) into dedicated handler files that follow the IIFE pattern to expose functions globally.

Key Changes

Moved extractLocation, extractEducation, and extractAchievements functions from script.js to separate files in web/model/parsing/
Enhanced extractAchievements function with more comprehensive achievement detection including Latin honors, scholarships, fellowships, and competition awards
Completely rewrote extractLocation function with improved multi-country support (US and India) and more robust location parsing
Standardized code formatting with consistent 4-space indentation in date/time parsing functions

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
`web/script.js`	Removed 403 lines of extraction functions and reformatted indentation for date parsing utilities
`web/model/parsing/location_text_handler.js`	New file implementing enhanced location extraction with support for US/Indian states, cities, and postal codes
`web/model/parsing/education_text_handler.js`	New file containing education level classification logic extracted from `script.js`
`web/model/parsing/achievement_text_handler.js`	New file with significantly expanded achievement detection beyond the original Dean's/Chancellor's List
`web/index.html`	Added script tags to load the three new text handler modules before `script.js`

Comments suppressed due to low confidence (1)

web/model/parsing/location_text_handler.js:4

Unused variable STATE_ABBR.

    const STATE_ABBR = [

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-10T01:14:18Z

@@ -0,0 +1,200 @@
+// educationClassifier.js


The file comment says // educationClassifier.js but the actual filename is education_text_handler.js. Update the comment to match the filename for consistency.

Suggested change

// educationClassifier.js

// education_text_handler.js

Copilot · 2025-12-10T01:14:19Z

@@ -0,0 +1,55 @@
+// achievementClassifier.js


The file comment says // achievementClassifier.js but the actual filename is achievement_text_handler.js. Update the comment to match the filename for consistency.

Suggested change

// achievementClassifier.js

// achievement_text_handler.js

Copilot · 2025-12-10T01:14:19Z

+    const STATE_ABBR = [
+        'AL', 'AK', 'AZ', 'AR', 'CA', 'CO', 'CT', 'DE', 'FL', 'GA', 'HI', 'ID', 'IL', 'IN', 'IA', 'KS', 'KY', 'LA', 'ME', 'MD', 'MA', 'MI', 'MN', 'MS', 'MO', 'MT', 'NE', 'NV', 'NH', 'NJ', 'NM', 'NY', 'NC', 'ND', 'OH', 'OK', 'OR', 'PA', 'RI', 'SC', 'SD', 'TN', 'TX', 'UT', 'VT', 'VA', 'WA', 'WV', 'WI', 'WY', 'DC'
+    ];


The STATE_ABBR constant is declared but never used in this file. The state abbreviations are already hardcoded in the regex pattern on line 26. Consider removing this unused constant or refactoring the findCityState function to use it for better maintainability.

Copilot · 2025-12-10T01:14:19Z

+        /\baa\b\b|\ba\.?\s*a\.?\b/,
+        /\bas\b\b|\ba\.?\s*s\.?\b/,


The regex patterns have a duplicate word boundary \b\b at the beginning. This should be \b only. The first part should be /\baa\b|\ba\.?\s*a\.?\b/ and the second should be /\bas\b|\ba\.?\s*s\.?\b/.

Suggested change

/\baa\b\b|\ba\.?\s*a\.?\b/,

/\bas\b\b|\ba\.?\s*s\.?\b/,

/\baa\b|\ba\.?\s*a\.?\b/,

/\bas\b|\ba\.?\s*s\.?\b/,

Copilot · 2025-12-10T01:14:20Z

+
+    if (
+        bachelorPositive.some(r => r.test(text)) &&
+        !bachelorNegative.some(r => r.test(text))


Missing arrow function syntax. This should be !bachelorNegative.some(r => r.test(text)) instead of !bachelorNegative.some(r.test(text)). The current code will throw a runtime error because r.test is attempting to access a property on the callback parameter r directly instead of calling test as a method.

Copilot · 2025-12-10T01:14:20Z

+    <!-- First load the classifier -->
    <!-- PDF.js -->
    <script src="https://cdnjs.cloudflare.com/ajax/libs/pdf.js/3.11.174/pdf.min.js"></script>
    <!-- Mammoth.js -->
    <script src="https://cdnjs.cloudflare.com/ajax/libs/mammoth/1.6.0/mammoth.browser.min.js"></script>
    <script src="model/data/skill_dict.js"></script>


The comment "First load the classifier" is misleading because the scripts being loaded are text handlers/extractors, not classifiers. Additionally, it's placed before the PDF.js comment. Consider moving it to line 84 before the actual text handler scripts, or updating it to say "Load text extraction handlers" for clarity.

Suggested change





<script src="https://cdnjs.cloudflare.com/ajax/libs/pdf.js/3.11.174/pdf.min.js"></script>



<script src="https://cdnjs.cloudflare.com/ajax/libs/mammoth/1.6.0/mammoth.browser.min.js"></script>

<script src="model/data/skill_dict.js"></script>



<script src="https://cdnjs.cloudflare.com/ajax/libs/pdf.js/3.11.174/pdf.min.js"></script>



<script src="https://cdnjs.cloudflare.com/ajax/libs/mammoth/1.6.0/mammoth.browser.min.js"></script>

<script src="model/data/skill_dict.js"></script>

Copilot · 2025-12-10T01:14:20Z

@@ -0,0 +1,110 @@
+// locationClassifier.js


The file comment says // locationClassifier.js but the actual filename is location_text_handler.js. Update the comment to match the filename for consistency.

Suggested change

// locationClassifier.js

// location_text_handler.js

lramos0 · 2025-12-10T03:20:32Z

@@ -0,0 +1,200 @@
+// educationClassifier.js
+(function (global) {


please remove this file from your git commits if you plan on merging this

I took your branch earlier and added mine, how should I do this?

lramos3 and others added 2 commits December 9, 2025 14:25

LOG: introduce education_text_handler.js

1161ce9

feat: add achievement and location text handlers; update script imports

e7e2832

utakbhate0943-dot requested review from Copilot and lramos0 December 10, 2025 01:10

Copilot started reviewing on behalf of utakbhate0943-dot December 10, 2025 01:11 View session

Copilot AI reviewed Dec 10, 2025

View reviewed changes

lramos0 requested changes Dec 10, 2025

View reviewed changes

Delete web/index.html

aa5aabf

utakbhate0943-dot added the DO NOT MERGE label Dec 10, 2025

utakbhate0943-dot changed the title ~~Uma achievementlocation~~ Uma achiloc1 Dec 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uma achiloc1#47

Uma achiloc1#47
utakbhate0943-dot wants to merge 3 commits into
mainfrom
uma-achievementlocation

utakbhate0943-dot commented Dec 9, 2025

Uh oh!

netlify Bot commented Dec 9, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 10, 2025

Uh oh!

Copilot AI Dec 10, 2025

Uh oh!

Copilot AI Dec 10, 2025

Uh oh!

Copilot AI Dec 10, 2025

Uh oh!

Copilot AI Dec 10, 2025

Uh oh!

Copilot AI Dec 10, 2025

Uh oh!

Copilot AI Dec 10, 2025

Uh oh!

lramos0 Dec 10, 2025

Uh oh!

utakbhate0943-dot Dec 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		@@ -0,0 +1,200 @@
		// educationClassifier.js
		(function (global) {

Conversation

utakbhate0943-dot commented Dec 9, 2025

Uh oh!

netlify Bot commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for mewannajob ready!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Copilot AI Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

lramos0 Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

utakbhate0943-dot Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

netlify Bot commented Dec 9, 2025 •

edited

Loading