Migrate JavaScript FFI dependencies to node:sqlite#28
Open
Migrate JavaScript FFI dependencies to node:sqlite#28
Conversation
lpil
reviewed
Feb 5, 2026
Owner
lpil
left a comment
lpil
left a comment
There was a problem hiding this comment.
Brilliant, thank you!
Could you rebase on main and update the code to remove the use of private FFI APIs please 🙏
Because this is a breaking change, it can only run on Node.js v22.5 or Deno v2.2 and later.
Comamoca
force-pushed
the
feature/node-sqlite
branch
from
52c616f to
ab22d2e
Compare
Author
|
@lpil |
Owner
|
Is this ready for a review? If so, please press the "ready for review" button and tag me 🙏 |
Author
|
@lpil |
lpil
reviewed
Mar 26, 2026
…sses to use the JS FFI format
Author
|
@lpil |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing the library used for JavaScript FFI to
node:sqlite.With this change, sqlight will be compatible with both Deno and Node.js.
This library relies on a fix merged in Deno v2.6.4, so you must use Deno version 2.6.4 or higher when running it.
Additionally, since Node.js is now a supported runtime, I have added commands to GitHub Actions to execute tests using Node.js.
close #21