Merged
Conversation
lpil
reviewed
Oct 19, 2025
Owner
lpil
left a comment
There was a problem hiding this comment.
Seeing as this is a library should we use something like import { DB } from "https://deno.land/x/sqlite/mod.ts";?
Contributor
Author
|
That's actually what I did at first, but then got to wondering if there wasn't a good reason for pinning a specific version that I was missing... 😅 Sounds good to me! Upinned the version! 👍 |
lpil
reviewed
Oct 20, 2025
Owner
lpil
left a comment
There was a problem hiding this comment.
Fab! Could you update the changelog please 🙏
Contributor
Author
|
Updated! And bumped the patch version. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! 👋
I was running into the following error trying to get
sqlightworking with Deno:And it appears that
Deno.seekSynchas been removed, which breaksx/sqlite@v3.7.0for modern Deno versions.I bumped the version to latest (
@3.9.1) and everything works (deno 2.5.4), but I'm not sure the consequences of setting this version, so please let me know if it should be something lower, or how I should go about determining what version to set it to.Thanks in advance! 🙏
Cheers,
Brad
P.S. - I've pivoted off of my Electon + Lustre mission to Tauri + Deno + Lustre, and
sqlightis going to be a huge help! 😁