This repository was archived by the owner on Mar 8, 2020. It is now read-only.
Add test to partner_request_spec - #7
Open
ryanbla wants to merge 19 commits into
Open
Conversation
…y isn't set in partner_request_spec
ryanbla
marked this pull request as ready for review
February 21, 2019 04:26
Member
|
@mdworken seems there's a question here. Can you help out? |
Collaborator
|
@ryanbla @nihonjinrxs looks like you all might have found a bug! I'll get a clearer answer to what's going on tonight. |
…kto_classes fix line item removal bug
…ation-email Spelling corrections partner invitation email
…associated-to-partner-request Validate items when validating a partner request
added xs adult brief size to hash
Add NDBN agency type classification drop down form
Collaborator
|
Can you fix the indentation for this file? |
ryanbla
changed the title
Author
|
@mdworken can you please re-review. I think this is ready |
Member
|
@ryanbla you'll need to merge master into this branch again, as it's out of date again. |
Member
|
@mdworken when you get a chance, please review this again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #2
Description
This PR addresses #2 Group 1, Bullet 1:
This is my attempt to write a test that the
PartnerRequestdisallows an item attribute if the quantity isn't set on an item in the request.from my understanding I am supposed to have a nil value for quantity and try to modify another value on the request. The problem is item.rb disallows quantity from being less than 1.
Am I misunderstanding this?
Ive tried setting partner_request_with_items' quantity to nil and then trying to modify the name.
I would expect partner_request_with_items.save to be false and to return an error message.
this is returning true and i think its because quantity is not being set to nil.
Type of change