Fail closed on empty channel allowlists#22
Open
lawyered0 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR closes a critical channel-authentication gap by requiring explicit sender allowlists by default.
Critical issue addressed
Telegram and Discord startup previously treated empty
allowFromas open mode, allowing any external user to interact with the bot when enabled.What changed
internal/channels/security.go:PICOBOT_ALLOW_PUBLIC_CHANNELS=1is now required to opt into public/open channel mode.internal/channels/telegram.go:allowFromis empty unless public mode is explicitly enabled.internal/channels/discord.go:allowFromis empty unless public mode is explicitly enabled.internal/channels/telegram_test.go(reject emptyallowFromby default)internal/channels/discord_test.go(reject emptyallowFromby default)internal/channels/security_test.go(env gate behavior)Validation
go test ./internal/channels -count=1go test ./...Compatibility note
Users relying on implicit open mode must now explicitly set
PICOBOT_ALLOW_PUBLIC_CHANNELS=1.