Harden exec tool against command-exec bypasses#21
Open
lawyered0 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR hardens the
exectool to close critical command-execution bypasses.Critical issue addressed
The previous guard validated only
argv[0]against an allowlist. Some allowlisted binaries can execute arbitrary commands internally (for example,gitaliases andfind -exec), which bypassed the intended safety boundary.What changed
internal/agent/tools/exec.go:git,find,rg) from the default allowlist.PICOBOT_EXEC_ALLOW_UNSAFE=1for trusted environments.internal/agent/loop.go:internal/agent/tools/exec_test.gointernal/agent/loop_exec_workspace_test.gogitalias andfind -exec) and workspace scoping behavior.Validation
go test ./internal/agent/tools -run Exec -count=1go test ./...Risk note
Setting
PICOBOT_EXEC_ALLOW_UNSAFE=1intentionally re-enables non-allowlisted binaries and should be used only in trusted environments.