Optimize search result DTO conversion#155
Draft
Bobbls wants to merge 1 commit into
Draft
Conversation
Bobbls
force-pushed
the
codex/optimize-search-results
branch
from
2721881 to
ee1b51f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Search results are transient Stremio items. Running them through IDtoService.GetBaseItemDto can dominate request time, especially when the client asks for a small page but Gelato converts the full result set first.
In local testing, one 'star' search moved from about 603ms search / 4859ms total to about 1665ms search / 1665ms total. Remaining slow cases tracked upstream Stremio/addon latency.
Validation