refactor: share runtime id generation#173
Open
Genmin wants to merge 1 commit into
Open
Conversation
Hilo-re
approved these changes
May 3, 2026
Collaborator
Hilo-re
left a comment
There was a problem hiding this comment.
Clean extraction. Same logic, zero duplication — exactly what the issue asked for. We'll confirm bun test passes on our end before merging.
Hilo-re
reviewed
May 8, 2026
Collaborator
Hilo-re
left a comment
There was a problem hiding this comment.
Code looks right — clean extraction, test follows the existing pattern, export placed correctly in index.ts. One thing before I merge: can you confirm bun test passes locally? The CI doesn't gate on it, but the project relies on Bun for testing and it's worth verifying the new test actually runs.
Collaborator
|
Missed that you already noted Bun isn't available locally — that's fine. We'll run the tests on our end before merging. Should be quick. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generateId()helperCloses #61
Validation
tsc -p packages/runtime/tsconfig.json --noEmitbiome check packages/runtime/src/id.ts packages/runtime/src/id.test.ts packages/runtime/src/message.ts packages/runtime/src/crash.ts packages/runtime/src/index.tsgit diff --checkNote
bun test; the added test follows the existingbun:teststyle and is covered by typecheck.