Skip to content

Clarify and honor saved context page continuation - #8318

Open
loopx-agent wants to merge 1 commit into
mainfrom
codex/context-opening-required-remainder-20261108
Open

loopx-agent wants to merge 1 commit into
mainfrom
codex/context-opening-required-remainder-20261108

Conversation

@loopx-agent

Copy link
Copy Markdown
Collaborator

Problem

A bounded saved-context opening can reach EOF while the initial read still has a required remainder. Its page instruction points only to the ordinary cursor within that selection. A caller can miss the remainder and reconstruct the pre-work read with broader manual selections. The same entry point rejects an explicit --page-bytes before reaching its window validator.

Change

  • Point the opening's existing page instruction to navigation.remaining_read_command and its cursor before work.
  • Let explicit page windows reach the existing validator for attached initial and selected reads.
  • Exercise an ordinary complete page, a staged opening and remainder, tight and explicit windows, invalid limits, and recovery of the same captured decision.

The saved-context CLI transport owns the instruction. The same captured Goal, Agent, Turn and digest bind the opening and remainder.

Validation

  • Ran the benchmark-profile CLI on the same immutable input at base and head. Both delivered the same 69 selected addresses and original receipt through the opening and remainder. The candidate opening fit within the default 12,000-byte serialized response limit.
  • Exact-head local quick premerge, public boundary, Ruff and bilingual diff checks passed.
  • Saved context and first-read suites produced 137 passing cases and 14 skips. Two warm native checkpoint tests expect delta and receive full delivery on both this head and the exact main base. All seven focused page-window cases pass, including three restored window cases.
  • Live model follow-through and whole-turn savings remain to be measured.

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
@mergify

mergify Bot commented Nov 7, 2026

Copy link
Copy Markdown

This pull request has merge conflicts with main and cannot be merged
until they are resolved. Please rebase or merge the base branch, @loopx-agent.

Choose the remote for the base repository, not an out-of-date fork.
For a fork clone, first inspect git remote -v; upstream must point
to https://github.com/loopx-project/loopx.git. If it is absent, add it
with git remote add upstream https://github.com/loopx-project/loopx.git.
Then run:

git fetch upstream
git rebase upstream/main
# Resolve each conflict, git add the resolved files, then git rebase --continue.
git push --force-with-lease origin HEAD

For a same-repository clone whose origin points to
https://github.com/loopx-project/loopx.git, use origin instead of
upstream for fetch/rebase. If you prefer merging the base, use
git merge <base-remote>/main and push normally.

Keep the DCO Signed-off-by trailer on every commit when you rebase.
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify Bot added the needs-rebase Mergify: the pull request has merge conflicts with its base branch label Nov 7, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase Mergify: the pull request has merge conflicts with its base branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant